Refactor about:sync's events framework

chrome/browser/resources/sync_internals/about.js

Index: chrome/browser/resources/sync_internals/about.js
diff --git a/chrome/browser/resources/sync_internals/about.js b/chrome/browser/resources/sync_internals/about.js
index d915fd77a1490047a503254fdd6396739e9e54df..071052682fc0dd4201e65d471532770f477e44d6 100644
--- a/chrome/browser/resources/sync_internals/about.js
+++ b/chrome/browser/resources/sync_internals/about.js
@@ -34,9 +34,11 @@ function onLoad() {
   $('status-data').hidden = true;
   chrome.sync.getAboutInfo(refreshAboutInfo);
 
-  chrome.sync.onServiceStateChanged.addListener(function() {
-    chrome.sync.getAboutInfo(refreshAboutInfo);
-  });
+  chrome.sync.events.addEventListener(
+      'onServiceStateChanged',
+      function(e) {
+        chrome.sync.getAboutInfo(refreshAboutInfo);
+      });
 
   var dumpStatusButton = $('dump-status');
   dumpStatusButton.addEventListener('click', function(event) {
@@ -75,7 +77,9 @@ function onLoad() {
     data = data.substr(firstBrace);
 
     // Remove listeners to prevent sync events from overwriting imported data.
-    chrome.sync.onServiceStateChanged.removeListeners();
+    chrome.sync.removeEventListener(

[Dan Beam, 2014/02/11 23:21:48]

should this be chrome.sync.events.removeEventListener?

[rlarocque, 2014/02/12 00:39:55]

Good catch.  Fixed.

I've also added a unit test that would have caught this error.

+        'onServiceStateChanged',
+        refreshAboutInfo);
 
     var aboutInfo = JSON.parse(data);
     refreshAboutInfo(aboutInfo);