Issue 160081: Add link to themes gallery....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160081: Add link to themes gallery.... (Closed)

Created:
11 years, 5 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
tony, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add link to themes gallery. BUG=16381 TEST=Go to second page of options, verify that the 'Get themes' button opens a new tab and takes you to the themes gallery. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21510

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -5 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	chrome/browser/views/options/content_page_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/options/content_page_view.cc	View	6 chunks	+28 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

Will you be making this change for linux and mac as well? http://codereview.chromium.org/160081/diff/1/3 File chrome/app/resources/locale_settings.grd ...

11 years, 5 months ago (2009-07-24 17:43:04 UTC) #3

Glen Murphy

11 years, 5 months ago (2009-07-24 17:48:13 UTC) #4

http://crbug.com/17641 was filed to cover the other platforms.

> Are theme launching for en only?

Yes.

On Fri, Jul 24, 2009 at 10:43 AM, <tony@chromium.org> wrote:
> Will you be making this change for linux and mac as well?
>
>
> http://codereview.chromium.org/160081/diff/1/3
> File chrome/app/resources/locale_settings.grd (right):
>
> http://codereview.chromium.org/160081/diff/1/3#newcode560
> Line 560: https://tools.google.com/chrome/intl/en/themes/index.html
> Are theme launching for en only? =A0By setting translateable=3D"false",
> you're saying this URL is the same for all languages.
>
> http://codereview.chromium.org/160081
>

Expand Messages | Collapse Messages