sdk/lib/_internal/compiler/implementation/lib/js_number.dart - Issue 16008002: Revert "Make int a double in argument type checks."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_number.dart

Issue 16008002: Revert "Make int a double in argument type checks." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/native_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_number.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_number.dart b/sdk/lib/_internal/compiler/implementation/lib/js_number.dart

index 445e927cbc5165db1d81c3c280129aee7f5a54e5..b6219e718ca6044f7f92462d8b3f98c5bc5e62be 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_number.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_number.dart

@@ -264,14 +264,7 @@ class JSNumber extends Interceptor implements num {

}

-/**

- * The interceptor class for [int]s.

- *

- * This class implements double since in JavaScript all numbers are doubles, so

- * while we want to treat `2.0` as an integer for some operations, its

- * interceptor should answer `true` to `is double`.

- */

-class JSInt extends JSNumber implements int, double {

+class JSInt extends JSNumber implements int {

const JSInt();

bool get isEven => (this & 1) == 0;