[Resumption 10/12] Use DI::IsDone to check for terminal downloads.

chrome/browser/download/download_shelf_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_shelf_context_menu.h"
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_prefs.h"
@@ skipping 111 matching lines @@
         prefs->DisableAutoOpenBasedOnExtension(path);
       break;
     }
     case CANCEL:
       download_item_->Cancel(true /* Cancelled by user */);
       break;
     case TOGGLE_PAUSE:
       // It is possible for the download to complete before the user clicks the
       // menu item, recheck if the download is in progress state before toggling
       // pause.
-      if (download_item_->IsPartialDownload()) {
+      if (download_item_->GetState() == DownloadItem::IN_PROGRESS) {
         if (download_item_->IsPaused())
           download_item_->Resume();
         else
           download_item_->Pause();
       }
       break;
     case DISCARD:
       download_item_->Remove();
       break;
     case KEEP:
@@ skipping 33 matching lines @@
 
 bool DownloadShelfContextMenu::IsItemForCommandIdDynamic(int command_id) const {
   return command_id == TOGGLE_PAUSE;
 }
 
 string16 DownloadShelfContextMenu::GetLabelForCommandId(int command_id) const {
   switch (static_cast<ContextMenuCommands>(command_id)) {
     case SHOW_IN_FOLDER:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_SHOW);
     case OPEN_WHEN_COMPLETE:
-      if (download_item_ &&
-          download_item_->GetState() == DownloadItem::IN_PROGRESS)
+      if (download_item_ && download_item_->IsPartialDownload())

[Randy Smith (Not in Mondays), 2013/06/05 20:21:44]

Do we persist the open state across browser restarts?

[asanka, 2013/06/05 21:33:47]

We persist the "opened" state, but not the "will open when complete" state.
Added to the list, but I think it's going to be very low priority.

         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN);
     case ALWAYS_OPEN_TYPE:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE);
     case CANCEL:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_CANCEL);
     case TOGGLE_PAUSE:
       if (download_item_ && download_item_->IsPaused())
         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_RESUME_ITEM);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_PAUSE_ITEM);
@@ skipping 94 matching lines @@
   malicious_download_menu_model_->AddItemWithStringId(
       DISCARD, IDS_DOWNLOAD_MENU_DISCARD);
   malicious_download_menu_model_->AddItemWithStringId(
       KEEP, IDS_DOWNLOAD_MENU_KEEP);
   malicious_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   malicious_download_menu_model_->AddItemWithStringId(
       LEARN_MORE_SCANNING, IDS_DOWNLOAD_MENU_LEARN_MORE_SCANNING);
 
   return malicious_download_menu_model_.get();
 }