Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6700)

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 160064: Push bookmarks.remove/removeAll polymorphism into c++. fix bookmarks id schema issues (Closed)
Patch Set: presubmit Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/common_resources.grd ('k') | chrome/renderer/extensions/extension_api_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api.json
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json
index 759d17aed358a5b3e0dd7229f9d6a832e26bd0fc..8e8aa521cdbc0a9947ec1c75474b3c78f95e7b16 100755
--- a/chrome/common/extensions/api/extension_api.json
+++ b/chrome/common/extensions/api/extension_api.json
@@ -492,8 +492,8 @@
{
name: "idOrIdList",
choice : [
- {type: "integer", minimum: 0},
- {type: "array", item: {type: "integer", minimum: 0}, minItems: 1}
+ {type: "string"},
+ {type: "array", item: {type: "string"}, minItems: 1}
]
},
{type: "function", name: "callback"}
@@ -504,7 +504,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{type: "function", name: "callback"}
]
},
@@ -534,7 +534,7 @@
type: "object",
name: "bookmark",
properties: {
- parentId: {type: "integer", minimum: 0, optional: true},
+ parentId: {type: "string"},
index: {type: "integer", minimum: 0, optional: true},
title: {type: "string", optional: true},
url: {type: "string", optional: true},
@@ -548,12 +548,12 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "destination",
properties: {
- parentId: {type: "integer", minimum: 0, optional: true},
+ parentId: {type: "string"},
index: {type: "integer", minimum: 0, optional: true}
}
},
@@ -565,7 +565,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "changes",
@@ -576,6 +576,24 @@
{type: "function", name: "callback", optional: true}
]
},
+ {
+ name: "remove",
+ type: "function",
+ description: "",
+ parameters: [
+ {type: "string", name: "id"},
+ {type: "function", name: "callback", optional: true}
+ ]
+ },
+ {
+ name: "removeTree",
+ type: "function",
+ description: "",
+ parameters: [
+ {type: "string", name: "id"},
+ {type: "function", name: "callback", optional: true}
+ ]
+ },
],
events: [
{
@@ -583,7 +601,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "bookmark",
@@ -595,7 +613,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "RemoveInfo",
@@ -607,7 +625,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "ChangeInfo",
@@ -619,7 +637,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "MoveInfo",
@@ -631,7 +649,7 @@
type: "function",
description: "",
parameters: [
- {type: "integer", name: "id", minimum: 0},
+ {type: "string", name: "id"},
{
type: "object",
name: "childIds",
« no previous file with comments | « chrome/common/common_resources.grd ('k') | chrome/renderer/extensions/extension_api_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698