Push bookmarks.remove/removeAll polymorphism into c++. fix bookmarks id schema issues

chrome/renderer/extensions/extension_api_client_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/extensions/extension_process_bindings.h"
@@ skipping 409 matching lines @@
 
   ExpectJsPass("chrome.tabs.remove(2)",
                "tabs.remove", "2");
 }
 
 // Bookmark API tests
 // TODO(erikkay) add more variations here
 
 TEST_F(ExtensionAPIClientTest, CreateBookmark) {
   ExpectJsFail(
-      "chrome.bookmarks.create({parentId:'x', title:0}, function(){})",
+      "chrome.bookmarks.create({parentId:0, title:0}, function(){})",
       "Uncaught Error: Invalid value for argument 0. "
-      "Property 'parentId': Expected 'integer' but got 'string', "
+      "Property 'parentId': Expected 'string' but got 'integer', "
       "Property 'title': Expected 'string' but got 'integer'.");
 
   ExpectJsPass(
-      "chrome.bookmarks.create({parentId:0, title:'x'}, function(){})",
+      "chrome.bookmarks.create({parentId:'0', title:'x'}, function(){})",
       "bookmarks.create",
-      "{\"parentId\":0,\"title\":\"x\"}");
+      "{\"parentId\":\"0\",\"title\":\"x\"}");
 }
 
 TEST_F(ExtensionAPIClientTest, GetBookmarks) {
-  ExpectJsPass("chrome.bookmarks.get(0, function(){});",
+  ExpectJsPass("chrome.bookmarks.get('0', function(){});",
                "bookmarks.get",
-               "0");
-  ExpectJsPass("chrome.bookmarks.get([0,1,2,3], function(){});",
+               "\"0\"");
+  ExpectJsPass("chrome.bookmarks.get(['0','1','2','3'], function(){});",
                "bookmarks.get",
-               "[0,1,2,3]");
+               "[\"0\",\"1\",\"2\",\"3\"]");
   ExpectJsFail("chrome.bookmarks.get(null, function(){});",
                "Uncaught Error: Parameter 0 is required.");
   // TODO(erikkay) This is succeeding, when it should fail.
   // BUG=13719
 #if 0
   ExpectJsFail("chrome.bookmarks.get({}, function(){});",
                "Uncaught Error: Invalid value for argument 0. "
                "Expected 'array' but got 'object'.");
 #endif
 }
 
 TEST_F(ExtensionAPIClientTest, GetBookmarkChildren) {
-  ExpectJsPass("chrome.bookmarks.getChildren(42, function(){});",
+  ExpectJsPass("chrome.bookmarks.getChildren('42', function(){});",
                "bookmarks.getChildren",
-               "42");
+               "\"42\"");
 }
 
 TEST_F(ExtensionAPIClientTest, GetBookmarkTree) {
   ExpectJsPass("chrome.bookmarks.getTree(function(){});",
                "bookmarks.getTree",
                "null");
 }
 
 TEST_F(ExtensionAPIClientTest, SearchBookmarks) {
   ExpectJsPass("chrome.bookmarks.search('hello',function(){});",
                "bookmarks.search",
                "\"hello\"");
 }
 
 TEST_F(ExtensionAPIClientTest, RemoveBookmark) {
-  ExpectJsPass("chrome.bookmarks.remove(42);",
+  ExpectJsPass("chrome.bookmarks.remove('42');",
                "bookmarks.remove",
-               "[42,false]");
+               "\"42\"");
 }
 
 TEST_F(ExtensionAPIClientTest, RemoveBookmarkTree) {
-  ExpectJsPass("chrome.bookmarks.removeTree(42);",
+  ExpectJsPass("chrome.bookmarks.removeTree('42');",
                "bookmarks.removeTree",
-               "[42,true]");
+               "\"42\"");
 }
 
 TEST_F(ExtensionAPIClientTest, MoveBookmark) {
-  ExpectJsPass("chrome.bookmarks.move(42,{parentId:1,index:0});",
+  ExpectJsPass("chrome.bookmarks.move('42',{parentId:'1',index:0});",
                "bookmarks.move",
-               "[42,{\"parentId\":1,\"index\":0}]");
+               "[\"42\",{\"parentId\":\"1\",\"index\":0}]");
 }
 
 TEST_F(ExtensionAPIClientTest, SetBookmarkTitle) {
-  ExpectJsPass("chrome.bookmarks.update(42,{title:'x'});",
+  ExpectJsPass("chrome.bookmarks.update('42',{title:'x'});",
                "bookmarks.update",
-               "[42,{\"title\":\"x\"}]");
+               "[\"42\",{\"title\":\"x\"}]");
 }
 
 TEST_F(ExtensionAPIClientTest, EnablePageAction) {
   // Basic old-school enablePageAction call.
   ExpectJsPass("chrome.pageActions.enableForTab("
-               "\"dummy\", {tabId: 0, url: \"http://foo/\"});",
+               "'dummy', {tabId: 0, url: 'http://foo/'});",
                "pageActions.enableForTab",
                "[\"dummy\",{\"tabId\":0,\"url\":\"http://foo/\"}]");
   // Try both optional parameters (title and iconId).
   ExpectJsPass("chrome.pageActions.enableForTab("
-               "\"dummy\", {tabId: 0, url: \"http://foo/\","
-                           "title: \"a\", iconId: 0});",
+               "'dummy', {tabId: 0, url: 'http://foo/',"
+                           "title: 'a', iconId: 0});",
                "pageActions.enableForTab",
                "[\"dummy\",{\"tabId\":0,\"url\":\"http://foo/\","
                            "\"title\":\"a\",\"iconId\":0}]");
 
   // Now try disablePageAction.
   ExpectJsPass("chrome.pageActions.disableForTab("
-               "\"dummy\", {tabId: 0, url: \"http://foo/\"});",
+               "'dummy', {tabId: 0, url: 'http://foo/'});",
                "pageActions.disableForTab",
                "[\"dummy\",{\"tabId\":0,\"url\":\"http://foo/\"}]");
 }