Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 160054: Adds a new unit tests for layout tests formatting script.... (Closed)

Created:
11 years, 5 months ago by Glenn Wilson
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Adds a new unit tests for layout tests formatting script. R=ojan BUG=17595 TEST=Run test_output_formatter.bat -r, all tests should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -17 lines) Patch
M webkit/tools/layout_tests/layout_package/failure_finder.py View 11 chunks +36 lines, -17 lines 0 comments Download
A webkit/tools/layout_tests/layout_package/failure_finder_test.py View 1 chunk +210 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_output_formatter.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Glenn Wilson
I had to make some tweaks to the FailureFinder class to support download prevention, and ...
11 years, 5 months ago (2009-07-23 23:12:07 UTC) #1
ojan
11 years, 5 months ago (2009-07-27 21:57:01 UTC) #2
LGTM. Thanks for adding tests!

On 2009/07/23 23:12:07, gwilson wrote:
> I had to make some tweaks to the FailureFinder class to support download
> prevention, and also added some output suppression so it wouldn't spam output
> during tests.

Powered by Google App Engine
This is Rietveld 408576698