Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160053004: Add user preferences for Contextual Search. (Closed)

Created:
6 years, 10 months ago by Donn Denman
Modified:
6 years, 10 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a user preference for Contextual Search. BUG=341761 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250920

Patch Set 1 #

Patch Set 2 : Changed to Sync, and to be a single tri-state. #

Patch Set 3 : Change from an integer to a string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/profiles/profile.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Donn Denman
Dave, can you do this review? Thanks!
6 years, 10 months ago (2014-02-11 23:27:54 UTC) #1
DaveMoore
lgtm
6 years, 10 months ago (2014-02-12 16:34:04 UTC) #2
Donn Denman
The CQ bit was checked by donnd@chromium.org
6 years, 10 months ago (2014-02-12 18:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/donnd@chromium.org/160053004/1
6 years, 10 months ago (2014-02-12 18:03:14 UTC) #4
Donn Denman
The CQ bit was unchecked by donnd@chromium.org
6 years, 10 months ago (2014-02-12 19:40:55 UTC) #5
Donn Denman
Dave, our team decided to change this setting to be sync-able. While we're at it, ...
6 years, 10 months ago (2014-02-12 20:42:41 UTC) #6
DaveMoore
lgtm
6 years, 10 months ago (2014-02-12 23:04:42 UTC) #7
Donn Denman
The CQ bit was checked by donnd@chromium.org
6 years, 10 months ago (2014-02-12 23:10:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/donnd@chromium.org/160053004/280001
6 years, 10 months ago (2014-02-12 23:11:23 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 00:34:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262917
6 years, 10 months ago (2014-02-13 00:34:36 UTC) #11
Donn Denman
The CQ bit was checked by donnd@chromium.org
6 years, 10 months ago (2014-02-13 00:56:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/donnd@chromium.org/160053004/280001
6 years, 10 months ago (2014-02-13 00:58:01 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 03:22:15 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263189
6 years, 10 months ago (2014-02-13 03:22:16 UTC) #15
Donn Denman
The CQ bit was checked by donnd@chromium.org
6 years, 10 months ago (2014-02-13 03:30:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/donnd@chromium.org/160053004/280001
6 years, 10 months ago (2014-02-13 03:32:55 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 03:34:53 UTC) #18
Message was sent while issue was closed. 
Change committed as 250920

Powered by Google App Engine
This is Rietveld 408576698