Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 16004008: raise nag_max when running on windows (Closed)

Created:
7 years, 6 months ago by scottmg
Modified:
7 years, 2 months ago
Reviewers:
iannucci1, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

raise nag_max when running on windows I tried 2x to "fetch chromium" on a Z620 Win8 and was unable to complete successfully without something getting killed. I also tried 1x at nag_max=20, but had to go higher to complete successfully. My network and disk IO are probably high-end, so a larger buffer is probably reasonable. R=szager@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gclient_scm.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
7 years, 6 months ago (2013-05-31 15:57:19 UTC) #1
szager1
I'd like to understand this better before you do this. Even on Windows, there shouldn't ...
7 years, 6 months ago (2013-05-31 17:08:47 UTC) #2
scottmg
On 2013/05/31 17:08:47, szager1 wrote: > I'd like to understand this better before you do ...
7 years, 6 months ago (2013-05-31 17:16:23 UTC) #3
szager1
On 2013/05/31 17:16:23, scottmg wrote: > The machine is basically unusable during the initial sync ...
7 years, 6 months ago (2013-05-31 17:19:49 UTC) #4
scottmg
On 2013/05/31 17:19:49, szager1 wrote: > On 2013/05/31 17:16:23, scottmg wrote: > > > The ...
7 years, 6 months ago (2013-05-31 17:27:35 UTC) #5
scottmg
On 2013/05/31 17:27:35, scottmg wrote: > On 2013/05/31 17:19:49, szager1 wrote: > > On 2013/05/31 ...
7 years, 6 months ago (2013-06-20 19:48:08 UTC) #6
iannucci1
7 years, 6 months ago (2013-06-20 20:11:00 UTC) #7
I'm going to be doing a compatibility pass over fetch/recipes for
windows/mac, I'll make sure to cover this today+tomorrow.


On Thu, Jun 20, 2013 at 12:48 PM, <scottmg@chromium.org> wrote:

> On 2013/05/31 17:27:35, scottmg wrote:
>
>> On 2013/05/31 17:19:49, szager1 wrote:
>> > On 2013/05/31 17:16:23, scottmg wrote:
>> >
>> > > The machine is basically unusable during the initial sync (for 5-10
>>
> minutes)
>
>> > so
>> > > I'm guessing it's just very heavy IO contention which makes the larger
>>
> repos
>
>> > > thrash while resolving.
>> >
>> > This makes a lot of sense, and it explains why I haven't seen it in
>> testing
>>
> (I
>
>> > rarely do a full clean checkout).
>> >
>> > Before doing this, I'd like to try a different approach: limit the
>> number of
>> > full repo checkouts that gclient can run in parallel.
>>
>
>  sg.
>>
>
> Hi, after the latest thread on chromium-dev, I've gotten 2 more private
> mails
> that "fetch chromium" is unusable on Windows.
>
> Could we please figure out a mitigation if you don't like this one?
>
>
https://codereview.chromium.**org/16004008/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698