Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 16004006: Fix handle zapping interaction with NoHandleAllocation. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix handle zapping interaction with NoHandleAllocation. This makes sure that closed handle scopes are properly zapped even if an enclosing NoHandleAllocation shrunk the limit. It also unifies the code that performs scope closing for internal and external handle scopes. R=svenpanne@chromium.org TEST=cctest/test-api/NestedLockersNoTryCatch Committed: http://code.google.com/p/v8/source/detail?r=14876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M src/api.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/handles.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/handles-inl.h View 3 chunks +25 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-05-29 09:53:12 UTC) #1
Sven Panne
LGTM, but please include the fact that a test was fixed in the CL description, ...
7 years, 6 months ago (2013-05-29 10:58:12 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-05-29 11:09:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698