sdk/lib/_internal/compiler/implementation/ssa/tracer.dart - Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/bailout.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (revision 23325)

+++ sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (working copy)

@@ -367,9 +367,7 @@

String visitInvokeConstructorBody(HInvokeConstructorBody invoke) {

String target = invoke.element.name.slowToString();

- int offset = HInvoke.ARGUMENTS_OFFSET + 1;

- List arguments = invoke.inputs.sublist(offset);

- return visitGenericInvoke("Invoke constructor body", target, arguments);

+ return visitGenericInvoke("Invoke constructor body", target, invoke.inputs);

}

String visitForeign(HForeign foreign) {

@@ -553,8 +551,12 @@

}

String visitTypeConversion(HTypeConversion node) {

+ assert(node.inputs.length <= 2);

+ String otherInput = node.inputs.length == 2

kasperl 2013/05/29 10:01:20 I'd suggest () around the comparison.

ngeoffray 2013/05/29 10:14:16 Done.

+ ? temporaryId(node.inputs[1])

+ : '';

return "TypeConversion: ${temporaryId(node.checkedInput)} to "

- "${node.instructionType}";

+ "${node.instructionType} $otherInput";

}

String visitRangeConversion(HRangeConversion node) {