Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/snapshot/serialize.cc

Issue 1600353003: [runtime] remove left-over distinction between AccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | src/types.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/snapshot/serialize.h" 5 #include "src/snapshot/serialize.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/platform/platform.h" 9 #include "src/base/platform/platform.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 1549 matching lines...) Expand 10 before | Expand all | Expand 10 after
1560 } 1560 }
1561 1561
1562 1562
1563 bool PartialSerializer::ShouldBeInThePartialSnapshotCache(HeapObject* o) { 1563 bool PartialSerializer::ShouldBeInThePartialSnapshotCache(HeapObject* o) {
1564 // Scripts should be referred only through shared function infos. We can't 1564 // Scripts should be referred only through shared function infos. We can't
1565 // allow them to be part of the partial snapshot because they contain a 1565 // allow them to be part of the partial snapshot because they contain a
1566 // unique ID, and deserializing several partial snapshots containing script 1566 // unique ID, and deserializing several partial snapshots containing script
1567 // would cause dupes. 1567 // would cause dupes.
1568 DCHECK(!o->IsScript()); 1568 DCHECK(!o->IsScript());
1569 return o->IsName() || o->IsSharedFunctionInfo() || o->IsHeapNumber() || 1569 return o->IsName() || o->IsSharedFunctionInfo() || o->IsHeapNumber() ||
1570 o->IsCode() || o->IsScopeInfo() || o->IsExecutableAccessorInfo() || 1570 o->IsCode() || o->IsScopeInfo() || o->IsAccessorInfo() ||
1571 o->map() == 1571 o->map() ==
1572 startup_serializer_->isolate()->heap()->fixed_cow_array_map(); 1572 startup_serializer_->isolate()->heap()->fixed_cow_array_map();
1573 } 1573 }
1574 1574
1575 1575
1576 #ifdef DEBUG 1576 #ifdef DEBUG
1577 bool Serializer::BackReferenceIsAlreadyAllocated(BackReference reference) { 1577 bool Serializer::BackReferenceIsAlreadyAllocated(BackReference reference) {
1578 DCHECK(reference.is_valid()); 1578 DCHECK(reference.is_valid());
1579 DCHECK(!reference.is_source()); 1579 DCHECK(!reference.is_source());
1580 DCHECK(!reference.is_global_proxy()); 1580 DCHECK(!reference.is_global_proxy());
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2795 SerializedCodeData* scd = new SerializedCodeData(cached_data); 2795 SerializedCodeData* scd = new SerializedCodeData(cached_data);
2796 SanityCheckResult r = scd->SanityCheck(isolate, source); 2796 SanityCheckResult r = scd->SanityCheck(isolate, source);
2797 if (r == CHECK_SUCCESS) return scd; 2797 if (r == CHECK_SUCCESS) return scd;
2798 cached_data->Reject(); 2798 cached_data->Reject();
2799 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r); 2799 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);
2800 delete scd; 2800 delete scd;
2801 return NULL; 2801 return NULL;
2802 } 2802 }
2803 } // namespace internal 2803 } // namespace internal
2804 } // namespace v8 2804 } // namespace v8
OLDNEW
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | src/types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698