Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1600353003: [runtime] remove left-over distinction between AccessorInfo and ExecutableAccessorInfo (Closed)

Created:
4 years, 11 months ago by Toon Verwaest
Modified:
4 years, 11 months ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-reviews_googlegroups.com, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] remove left-over distinction between AccessorInfo and ExecutableAccessorInfo Committed: https://crrev.com/e4b41d64e582cf1b265a1bd6919d7288dfadfe10 Cr-Commit-Position: refs/heads/master@{#33364}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -196 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/accessors.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/accessors.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/context-measure.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +13 lines, -19 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 10 chunks +32 lines, -51 lines 0 comments Download
M src/objects.cc View 12 chunks +21 lines, -27 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/objects-inl.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/types.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
4 years, 11 months ago (2016-01-18 10:50:25 UTC) #2
Yang
serializer lgtm.
4 years, 11 months ago (2016-01-18 11:02:05 UTC) #4
Igor Sheludko
lgtm
4 years, 11 months ago (2016-01-18 11:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1600353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1600353003/20001
4 years, 11 months ago (2016-01-18 14:47:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-18 15:08:41 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 15:09:18 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e4b41d64e582cf1b265a1bd6919d7288dfadfe10
Cr-Commit-Position: refs/heads/master@{#33364}

Powered by Google App Engine
This is Rietveld 408576698