Issue 16003002: Add StreamController.multiplex constructor.

Issue 16003002: Add StreamController.multiplex constructor. (Closed)

Created:
7 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add StreamController.multiplex constructor. The "multiplex" stream controller will generate a new stream every time .stream is read on the controller, and it will send events to any stream that currently has a listener. The streams handle their own buffering. Events added before the listen are ignored. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=23217

Patch Set 1 #

Patch Set 2 : Add more test. #

Total comments: 4

Patch Set 3 : More methods on interface. Use multiplexer. #

Total comments: 3

Patch Set 4 : Merge on top of active streams #

Patch Set 5 : Remove unused code #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+255 lines, -103 lines)			Patch
M	pkg/mdv_observe/lib/src/observable_list.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/mock_clock.dart	View	1 2	3 chunks	+6 lines, -24 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1 2 3	7 chunks	+182 lines, -45 lines	0 comments	Download
M	sdk/lib/mdv_observe_impl/mdv_observe_impl.dart	View	1 2 3	2 chunks	+9 lines, -23 lines	0 comments	Download
M	sdk/lib/utf/utf_stream.dart	View	1 2 3 4	1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View	1 2 3	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/16003002/diff/3001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16003002/diff/3001/sdk/lib/async/stream_controller.dart#newcode223 sdk/lib/async/stream_controller.dart:223: void _recordListen(StreamSubscription<T> subscription) { Why not keep the ...

7 years, 7 months ago (2013-05-24 20:51:42 UTC) #2

Lasse Reichstein Nielsen

Please check changes. https://codereview.chromium.org/16003002/diff/3001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16003002/diff/3001/sdk/lib/async/stream_controller.dart#newcode223 sdk/lib/async/stream_controller.dart:223: void _recordListen(StreamSubscription<T> subscription) { True, it ...

7 years, 7 months ago (2013-05-27 08:04:12 UTC) #3

floitsch

SLGTM. https://codereview.chromium.org/16003002/diff/10001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16003002/diff/10001/sdk/lib/async/stream_controller.dart#newcode105 sdk/lib/async/stream_controller.dart:105: /** Whether there is currently a subscriber on ...

7 years, 7 months ago (2013-05-27 08:27:09 UTC) #4

Lasse Reichstein Nielsen

https://codereview.chromium.org/16003002/diff/10001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16003002/diff/10001/sdk/lib/async/stream_controller.dart#newcode105 sdk/lib/async/stream_controller.dart:105: /** Whether there is currently a subscriber on the ...

7 years, 7 months ago (2013-05-27 11:17:28 UTC) #5

Lasse Reichstein Nielsen

7 years, 7 months ago (2013-05-27 12:27:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r23217 (presubmit successful).

Expand Messages | Collapse Messages