Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1600263002: Post a task to the IO thread to add a ResourceContext in ResourceDispatcherHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move task posting to call site. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/resource_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 022f410c82590f05aa1ddc8bf3f01a1c6a174bfc..0b8009013f9973f5c0d8db1424d70c0f08700828 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -543,6 +543,7 @@ void ResourceDispatcherHostImpl::SetAllowCrossOriginAuthPrompt(bool value) {
}
void ResourceDispatcherHostImpl::AddResourceContext(ResourceContext* context) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
mmenke 2016/01/21 16:33:34 May want to add a DCHECK to RemoveResourceContext
Anand Mistry (off Chromium) 2016/01/21 19:41:52 The reason I didn't is because of the comment abou
active_resource_contexts_.insert(context);
}
« no previous file with comments | « no previous file | content/browser/resource_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698