Issue 1600253003: [try] Trigger compositionstart/end on commitText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1600253003: [try] Trigger compositionstart/end on commitText (Closed)

Created:
4 years, 11 months ago by Changwan Ryu

Modified:
4 years, 11 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
blink-reviews, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[try] Trigger compositionstart/end on commitText On Android, OSK may not accompany keycode when composing text. Currently, when OSK calls InputConnection#commitText(), web developers can only see key events for COMPOSITION_KEY_CODE without the delta change. By changing confirmComposition to send compositionstart / -end, we can notify developers of this delta change. BUG=577967

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -24 lines)			Patch
M	content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java	View	1 2 3 4	5 chunks	+26 lines, -19 lines	0 comments	Download
M	content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
A	content/test/data/android/ime/input_forms.html	View	1 2 3	1 chunk	+72 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/editing/InputMethodController.cpp	View	1 2	5 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

aelias_OOO_until_Jul13

4 years, 11 months ago (2016-01-19 21:31:20 UTC) #2

OK, since the layout tests explicitly expect this not to happen, let's abandon
this approach.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages