Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 160023003: Move webfallbackthemeengine_impl.* to content/child/ (Closed)

Created:
6 years, 10 months ago by pilgrim_google
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move webfallbackthemeengine_impl.* to content/child/ BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250930

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix namespace nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -251 lines) Patch
A + content/child/webfallbackthemeengine_impl.h View 2 chunks +6 lines, -9 lines 0 comments Download
A + content/child/webfallbackthemeengine_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webkitplatformsupport_child_impl.h View 1 2 chunks +2 lines, -2 lines 1 comment Download
M content/content_child.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
D webkit/child/webfallbackthemeengine_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/child/webfallbackthemeengine_impl.cc View 1 chunk +0 lines, -193 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pilgrim_google
6 years, 10 months ago (2014-02-11 19:36:56 UTC) #1
jamesr
The fallback theme engine is a strange thing. It appears to only exist to have ...
6 years, 10 months ago (2014-02-11 20:58:14 UTC) #2
pilgrim_google
6 years, 10 months ago (2014-02-12 20:22:52 UTC) #3
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 10 months ago (2014-02-12 21:40:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 21:45:47 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-12 21:45:48 UTC) #6
darin (slow to review)
LGTM https://codereview.chromium.org/160023003/diff/100001/content/child/webkitplatformsupport_child_impl.h File content/child/webkitplatformsupport_child_impl.h (right): https://codereview.chromium.org/160023003/diff/100001/content/child/webkitplatformsupport_child_impl.h#newcode68 content/child/webkitplatformsupport_child_impl.h:68: WebFallbackThemeEngineImpl fallback_theme_engine_; I agree with jamesr. The code ...
6 years, 10 months ago (2014-02-12 23:58:43 UTC) #7
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 10 months ago (2014-02-13 00:50:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/160023003/100001
6 years, 10 months ago (2014-02-13 00:50:46 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 03:57:29 UTC) #10
Message was sent while issue was closed.
Change committed as 250930

Powered by Google App Engine
This is Rietveld 408576698