Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: chrome/browser/chromeos/login/user_adding_screen.h

Issue 16002004: Added login screen mode for adding users into session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clang errors fixed. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_adding_screen.h
diff --git a/chrome/browser/chromeos/login/user_adding_screen.h b/chrome/browser/chromeos/login/user_adding_screen.h
new file mode 100644
index 0000000000000000000000000000000000000000..e8c833bfdccec3dfa85807596f96fb2ba9bdbbb5
--- /dev/null
+++ b/chrome/browser/chromeos/login/user_adding_screen.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
Nikita (slow) 2013/05/28 11:34:22 To make name more consistent this could be renamed
dzhioev (left Google) 2013/05/29 13:05:04 Decided to leave current name.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USER_ADDING_SCREEN_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_USER_ADDING_SCREEN_H_
+
+#include "base/basictypes.h"
+
+namespace chromeos {
+
+// An interface that defines screen for adding users into multiprofile session.
Nikita (slow) 2013/05/28 11:34:22 nit: multi-profile
dzhioev (left Google) 2013/05/29 13:05:04 Done.
+// Current implementation is singleton.
Nikita (slow) 2013/05/28 11:34:22 nit: Please add TODO to came up with a better desi
Nikita (slow) 2013/05/28 11:34:22 nit: is a
dzhioev (left Google) 2013/05/29 13:05:04 Done.
dzhioev (left Google) 2013/05/29 13:05:04 Done.
+class UserAddingScreen {
+ public:
+ struct Observer {
+ virtual void OnUserAddingStarted() {}
Nikita (slow) 2013/05/28 11:34:22 Body should go to .cc
dzhioev (left Google) 2013/05/29 13:05:04 I think it is OK to leave empty definitions of Obs
Nikita (slow) 2013/05/29 13:29:38 I think that violates http://dev.chromium.org/deve
+ virtual void OnUserAddingFinished() {}
+ virtual ~Observer() {}
+ };
+
+ static UserAddingScreen* Get();
+
+ virtual void Start() = 0;
+ virtual void Cancel() = 0;
+ virtual bool IsRunning() = 0;
+
+ virtual void AddObserver(Observer* observer) = 0;
+ virtual void RemoveObserver(Observer* observer) = 0;
+
+ protected:
+ UserAddingScreen();
+ virtual ~UserAddingScreen();
+
+ DISALLOW_COPY_AND_ASSIGN(UserAddingScreen);
+};
+
+} // namespace chromeos
+
+#endif // CHROME_BROWSER_CHROMEOS_LOGIN_USER_ADDING_SCREEN_H_
+

Powered by Google App Engine
This is Rietveld 408576698