Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 16001004: NaCl: Update revision in DEPS, r11397 -> r11406 (Closed)

Created:
7 years, 6 months ago by Mark Seaborn
Modified:
7 years, 6 months ago
CC:
chromium-reviews, binji, eliben, khim, Karl, native-client-reviews_googlegroups.com, Vlad Shcherbina
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r11397 -> r11406 This pulls in the following Native Client changes: r11398: (khim) Add few more test to automatically catch errors r11399: (eliben) Move the pnacl_info_template.json file from the Chrome repo to the NaCl repo. r11400: (mseaborn) Minidumper: Extend build ID reader to work with PNaCl toolchain on x86-64 r11401: (kschimpf) Update pnacl llvm revision r11402: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS r11403: (binji) build_nexe.py now normalizes paths before accessing the filesystem. r11404: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS r11405: (mseaborn) PNaCl: Switch to using "-pnacl-abi-simplify-{pre,post}opt" meta-passes r11406: (shcherbina) Factor out objdump parsing utils to separate module. BUG=none TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
7 years, 6 months ago (2013-05-28 22:01:51 UTC) #1
Nick Bray (chromium)
LGTM, although the Windows bot looks pretty messed up so it's hard to tell.
7 years, 6 months ago (2013-05-28 22:10:29 UTC) #2
Mark Seaborn
Committed patchset #1 manually as r202693 (presubmit successful).
7 years, 6 months ago (2013-05-28 23:53:06 UTC) #3
Mark Seaborn
7 years, 6 months ago (2013-05-28 23:53:31 UTC) #4
Message was sent while issue was closed.
On 2013/05/28 22:10:29, Nick Bray (chromium) wrote:
> LGTM, although the Windows bot looks pretty messed up so it's hard to tell.

I re-ran cros_daisy, win_rel_naclmore and linux_chromeos, and they passed.

Powered by Google App Engine
This is Rietveld 408576698