Issue 160003007: Mojo: Make a public test_support shared library.

Issue 160003007: Mojo: Make a public test_support shared library. (Closed)

Created:
6 years, 10 months ago by viettrungluu

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: Make a public test_support shared library. The test runner can then inject dependencies into it (just as we do for system and gles2). This removes public/tests's base dependency. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251115

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -8 lines)			Patch
M	mojo/common/test/run_all_perftests.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/common/test/run_all_unittests.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	mojo/common/test/test_support_impl.h	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	mojo/common/test/test_support_impl.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2	3 chunks	+15 lines, -0 lines	0 comments	Download
M	mojo/mojo_public.gypi	View	1 2	2 chunks	+23 lines, -1 line	0 comments	Download
M	mojo/public/tests/DEPS	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A	mojo/public/tests/test_support.h	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	mojo/public/tests/test_support_export.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	mojo/public/tests/test_support_private.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	mojo/public/tests/test_support_private.cc	View		1 chunk	+49 lines, -0 lines	0 comments	Download
M	mojo/public/tests/test_utils.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 8 (0 generated)

viettrungluu

(Dependent on https://codereview.chromium.org/132353006/.) It looks big, but it's nearly all boilerplate.

6 years, 10 months ago (2014-02-12 20:34:14 UTC) #1

viettrungluu

The CQ bit was checked by viettrungluu@chromium.org

6 years, 10 months ago (2014-02-13 17:58:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/160003007/1

6 years, 10 months ago (2014-02-13 17:59:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/160003007/1

6 years, 10 months ago (2014-02-13 19:54:11 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-13 20:17:09 UTC) #6

commit-bot: I haz the power

Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...

6 years, 10 months ago (2014-02-13 20:17:10 UTC) #7

viettrungluu

6 years, 10 months ago (2014-02-13 20:40:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r251115 (presubmit successful).