Issue 159993002: A64: Remove A64 special casing in ExternalCallbackScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159993002: A64: Remove A64 special casing in ExternalCallbackScope (Closed)

Created:
6 years, 10 months ago by rmcilroy

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Remove A64 special casing in ExternalCallbackScope R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19298

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	src/a64/simulator-a64.h	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	src/arm/simulator-arm.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/mips/simulator-mips.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/vm-state-inl.h	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

Committed patchset #1 manually as r19298 (presubmit successful).

6 years, 10 months ago (2014-02-11 18:53:44 UTC) #3

Rodolph Perfetta

6 years, 10 months ago (2014-02-12 01:08:51 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/159993002/diff/1/src/a64/simulator-a64.h
File src/a64/simulator-a64.h (right):

https://codereview.chromium.org/159993002/diff/1/src/a64/simulator-a64.h#newc...
src/a64/simulator-a64.h:448: Address get_sp() { return
reinterpret_cast<Address>(sp()); }
Late DBC, on a64 you can avoid the cast:

  Address get_sp() { return reg<Address>(31, Reg31IsStackPointer); }

Expand Messages | Collapse Messages