Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: src/code-stubs.h

Issue 159953002: A64: Remove A64 special casing from DoubleToIStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 8276bf61ba0c8a102cc38005825b313bf44a1d19..0a90dbbe13eb49e1b86b1ac9222ede851e355ec2 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1874,9 +1874,6 @@ class DoubleToIStub : public PlatformCodeStub {
int offset,
bool is_truncating,
bool skip_fastpath = false) : bit_field_(0) {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
- // so we don't need this special case.
bit_field_ = SourceRegisterBits::encode(source.code()) |
DestinationRegisterBits::encode(destination.code()) |
OffsetBits::encode(offset) |
@@ -1884,37 +1881,14 @@ class DoubleToIStub : public PlatformCodeStub {
SkipFastPathBits::encode(skip_fastpath) |
SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#else
- bit_field_ = SourceRegisterBits::encode(source.code_) |
- DestinationRegisterBits::encode(destination.code_) |
- OffsetBits::encode(offset) |
- IsTruncatingBits::encode(is_truncating) |
- SkipFastPathBits::encode(skip_fastpath) |
- SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
- CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#endif
}
Register source() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
- // so we don't need this special case.
- return Register::XRegFromCode(SourceRegisterBits::decode(bit_field_));
-#else
- Register result = { SourceRegisterBits::decode(bit_field_) };
- return result;
-#endif
+ return Register::from_code(SourceRegisterBits::decode(bit_field_));
}
Register destination() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
- // so we don't need this special case.
- return Register::XRegFromCode(DestinationRegisterBits::decode(bit_field_));
-#else
- Register result = { DestinationRegisterBits::decode(bit_field_) };
- return result;
-#endif
+ return Register::from_code(DestinationRegisterBits::decode(bit_field_));
}
bool is_truncating() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698