Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1599513004: XFA: Rename libpng to libpng16. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Rename libpng to libpng16. Otherwise this conflicts with Chromium's copy if the include paths just happens to be in the wrong order. Since the two copies of libpng are of different versions, we cannot use Chromium's copy. TBR=tsepez@chromium.org,ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a76a6d8bcb76077fa248b64c5d64791dc8f23771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36905 lines) Patch
M core/src/fxcodec/codec/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_png.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samples/image_diff_png.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 chunk +22 lines, -22 lines 0 comments Download
D third_party/libpng/0000-build-config.patch View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/libpng/0001-disable-arm-neon.patch View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/libpng/README.pdfium View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/libpng/png.h View 1 chunk +0 lines, -3130 lines 0 comments Download
D third_party/libpng/png.c View 1 chunk +0 lines, -4498 lines 0 comments Download
D third_party/libpng/pngconf.h View 1 chunk +0 lines, -622 lines 0 comments Download
D third_party/libpng/pngdebug.h View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/libpng/pngerror.c View 1 chunk +0 lines, -963 lines 0 comments Download
D third_party/libpng/pngget.c View 1 chunk +0 lines, -1219 lines 0 comments Download
D third_party/libpng/pnginfo.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/libpng/pnglibconf.h View 1 chunk +0 lines, -214 lines 0 comments Download
D third_party/libpng/pngmem.c View 1 chunk +0 lines, -287 lines 0 comments Download
D third_party/libpng/pngpread.c View 1 chunk +0 lines, -1085 lines 0 comments Download
D third_party/libpng/pngpriv.h View 1 chunk +0 lines, -1929 lines 0 comments Download
D third_party/libpng/pngread.c View 1 chunk +0 lines, -4136 lines 0 comments Download
D third_party/libpng/pngrio.c View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/libpng/pngrtran.c View 1 chunk +0 lines, -4997 lines 0 comments Download
D third_party/libpng/pngrutil.c View 1 chunk +0 lines, -4529 lines 0 comments Download
D third_party/libpng/pngset.c View 1 chunk +0 lines, -1647 lines 0 comments Download
D third_party/libpng/pngstruct.h View 1 chunk +0 lines, -483 lines 0 comments Download
D third_party/libpng/pngtrans.c View 1 chunk +0 lines, -849 lines 0 comments Download
D third_party/libpng/pngwio.c View 1 chunk +0 lines, -168 lines 0 comments Download
D third_party/libpng/pngwrite.c View 1 chunk +0 lines, -2230 lines 0 comments Download
D third_party/libpng/pngwtran.c View 1 chunk +0 lines, -576 lines 0 comments Download
D third_party/libpng/pngwutil.c View 1 chunk +0 lines, -2709 lines 0 comments Download
A + third_party/libpng16/0000-build-config.patch View 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/libpng16/0001-disable-arm-neon.patch View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/libpng16/README.pdfium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/png.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/png.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngconf.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngdebug.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngerror.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngget.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pnginfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pnglibconf.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngmem.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngpread.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngpriv.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngread.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngrio.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngrtran.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngrutil.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngset.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngstruct.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngtrans.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngwio.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngwrite.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngwtran.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libpng16/pngwutil.c View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/third_party.gyp View 1 chunk +22 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR Another alternative is to switch to libpng 1.2 to match Chromium, but that likely ...
4 years, 11 months ago (2016-01-16 03:37:57 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as a76a6d8bcb76077fa248b64c5d64791dc8f23771 (presubmit successful).
4 years, 11 months ago (2016-01-16 03:38:10 UTC) #3
Oliver Chang
4 years, 11 months ago (2016-01-16 04:02:14 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698