Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: runtime/vm/handles_impl.h

Issue 15995034: - Remove the unvisited handles code from handles implementation as it is not (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/handles.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/handles_impl.h
===================================================================
--- runtime/vm/handles_impl.h (revision 23690)
+++ runtime/vm/handles_impl.h (working copy)
@@ -49,23 +49,6 @@
template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
void Handles<kHandleSizeInWords,
kHandlesPerChunk,
- kOffsetOfRawPtr>::VisitUnvisitedScopedHandles(
- ObjectPointerVisitor* visitor) {
- HandlesBlock* block = &first_scoped_block_;
- while (block != NULL && block != last_visited_block_) {
- block->VisitUnvisitedObjectPointers(visitor);
- block = block->next_block();
- }
- // We want this to point to first_scoped_block.next,
- // Because pointers are still being added to first_scoped_block
- // So it may be "partially new", and require a partial scan.
- last_visited_block_ = first_scoped_block_.next_block();
-}
-
-
-template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
-void Handles<kHandleSizeInWords,
- kHandlesPerChunk,
kOffsetOfRawPtr>::Visit(HandleVisitor* visitor) {
// Visit all zone handles.
HandlesBlock* block = zone_blocks_;
@@ -339,24 +322,6 @@
template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
void Handles<kHandleSizeInWords,
kHandlesPerChunk,
- kOffsetOfRawPtr>::HandlesBlock::VisitUnvisitedObjectPointers(
- ObjectPointerVisitor* visitor) {
- ASSERT(visitor != NULL);
-
- // last_visited_handle_ picks up where we were last time,
- // so there is nothing in the intialization position of this for loop.
-
- while (last_visited_handle_ < next_handle_slot_) {
- last_visited_handle_ += kHandleSizeInWords;
- uword* addr = &data_[last_visited_handle_ + kOffsetOfRawPtr / kWordSize];
- visitor->VisitPointer(reinterpret_cast<RawObject**>(addr));
- }
-}
-
-
-template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
-void Handles<kHandleSizeInWords,
- kHandlesPerChunk,
kOffsetOfRawPtr>::HandlesBlock::Visit(HandleVisitor* visitor) {
ASSERT(visitor != NULL);
for (intptr_t i = 0; i < next_handle_slot_; i += kHandleSizeInWords) {
« no previous file with comments | « runtime/vm/handles.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698