Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: runtime/vm/handles.h

Issue 15995034: - Remove the unvisited handles code from handles implementation as it is not (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/handles_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/handles.h
===================================================================
--- runtime/vm/handles.h (revision 23690)
+++ runtime/vm/handles.h (working copy)
@@ -77,8 +77,7 @@
Handles()
: zone_blocks_(NULL),
first_scoped_block_(NULL),
- scoped_blocks_(&first_scoped_block_),
- last_visited_block_(NULL) {
+ scoped_blocks_(&first_scoped_block_) {
}
~Handles() {
DeleteAll();
@@ -139,8 +138,7 @@
class HandlesBlock {
public:
explicit HandlesBlock(HandlesBlock* next)
- : last_visited_handle_(0),
- next_handle_slot_(0),
+ : next_handle_slot_(0),
next_block_(next) { }
~HandlesBlock();
@@ -170,10 +168,6 @@
// Visit all object pointers in the handle block.
void VisitObjectPointers(ObjectPointerVisitor* visitor);
- // Visit all the object pointers in the block since the last time this
- // method was called.
- void VisitUnvisitedObjectPointers(ObjectPointerVisitor* visitor);
-
// Visit all of the handles in the handle block.
void Visit(HandleVisitor* visitor);
@@ -194,10 +188,6 @@
void set_next_block(HandlesBlock* next) { next_block_ = next; }
private:
- // Last handle visited by VisitUnvisitedObjectPointers. Handles
- // at, or beyond this index are new.
- intptr_t last_visited_handle_;
-
uword data_[kHandleSizeInWords * kHandlesPerChunk]; // Handles area.
intptr_t next_handle_slot_; // Next slot for allocation in current block.
HandlesBlock* next_block_; // Link to next block of handles.
@@ -234,8 +224,6 @@
HandlesBlock* zone_blocks_; // List of zone handles.
HandlesBlock first_scoped_block_; // First block of scoped handles.
HandlesBlock* scoped_blocks_; // List of scoped handles.
- // Last block visited by VisitUnvisitedHandles.
- HandlesBlock* last_visited_block_;
friend class HandleScope;
friend class Dart;
« no previous file with comments | « no previous file | runtime/vm/handles_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698