Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1599503002: DevTools: computed properties should copy-paste with delimeters (Closed)

Created:
4 years, 11 months ago by lushnikov
Modified:
4 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: computed properties should copy-paste with delimeters The patch adds transparent ":" and ";" delimeters to the computed properties rendering so that their copying results in a valid css syntax. BUG=568697 R=pfeldman, dgozman Committed: https://crrev.com/824c19017aa7b4c41a04341d994b2950ad597940 Cr-Commit-Position: refs/heads/master@{#370159}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -87 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-live-edit-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inactive-properties-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inherited-mixed-case-properties-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 1 2 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/region-style-crash-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt View 1 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
4 years, 11 months ago (2016-01-15 22:46:25 UTC) #1
dgozman
lgtm
4 years, 11 months ago (2016-01-19 17:57:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1599503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1599503002/20001
4 years, 11 months ago (2016-01-19 17:58:08 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 19:15:13 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 19:16:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/824c19017aa7b4c41a04341d994b2950ad597940
Cr-Commit-Position: refs/heads/master@{#370159}

Powered by Google App Engine
This is Rietveld 408576698