Issue 15995023: Add multicast support to DatagramServerSocket

Issue 15995023: Add multicast support to DatagramServerSocket (Closed)

Created:
7 years, 6 months ago by Noam Samuel

Modified:
7 years, 6 months ago

Reviewers:
Sergey Ulanov, szym

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add multicast support to DatagramServerSocket Add support for multicasting functions to DatagramServerSocket and UDPServerSocket. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205003

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Update comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -0 lines)			Patch
M	content/browser/renderer_host/p2p/socket_host_udp_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	net/udp/datagram_server_socket.h	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download
M	net/udp/udp_server_socket.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/udp/udp_server_socket.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://codereview.chromium.org/15995023/diff/3001/net/udp/datagram_server_socket.h File net/udp/datagram_server_socket.h (right): https://codereview.chromium.org/15995023/diff/3001/net/udp/datagram_server_socket.h#newcode73 net/udp/datagram_server_socket.h:73: // |group_address| is the group address to join, ...

7 years, 6 months ago (2013-06-07 19:59:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/15995023/8001

7 years, 6 months ago (2013-06-07 20:46:52 UTC) #4

Message was sent while issue was closed.

Change committed as 205003

Expand Messages | Collapse Messages