Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 15995017: CPU profiler should support names of accessors set via v8::Object::SetAccessor (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

CPU profiler should support names of accessors set via v8::Object::SetAccessor This change fixes the case when the accessors are invoked from JSObject::{Get,Set}PropertyWithCallback. It already works for inlined calls generated by StoreStubCompiler::CompileStoreCallback. The same still needs to be fixed for getter invocations generated by BaseLoadStubCompiler::CompileLoadCallback, corresponding case is commented out in the new test. This is a slightly modified version of r14915 which was rolled back due to test timeout on Windows. Compared to r14915 the new tests use OS::TimeCurrentMillis instead of OS::Ticks as OS::Ticks has ms precision on Windows and trying to wait 10 ticks (us) will result in at least 1 ms pause. BUG=244580 R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M src/objects.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +143 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 6 months ago (2013-06-03 16:16:56 UTC) #1
loislo
lgtm
7 years, 6 months ago (2013-06-03 16:56:53 UTC) #2
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-04 09:27:34 UTC) #3
yurys
7 years, 6 months ago (2013-06-04 10:57:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698