base/memory/memory_pressure_handler_list.h - Issue 15995014: Adds MemoryPressureListener.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/memory/memory_pressure_handler_list.h

Issue 15995014: Adds MemoryPressureListener. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Hooks up with MemoryPurger Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« base/memory/memory_pressure_handler.h ('K') | « base/memory/memory_pressure_handler.cc ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java » ('j') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum and a java class for the values.

	7

	8 #ifndef DEFINE_MEMORY_PRESSURE_TYPE

	9 #error "DEFINE_MEMORY_PRESSURE_TYPE should be defined."

	10 #endif

	11

	12 DEFINE_MEMORY_PRESSURE_TYPE(MEMORY_PRESSURE_LOW, 0)

	13 DEFINE_MEMORY_PRESSURE_TYPE(MEMORY_PRESSURE_MODERATE, 1)
	joth 2013/06/05 16:51:23 these need some descriptions. Tom's suggestions of these need some descriptions. Tom's suggestions of time it takes to recreate in the bug is nice starting point - although that depends on the foreground/background state too of the 'thing' being dropped, and it may seem confusing to talk about that here too. (It leads to the question of should this carry for/background state too, but that's domain specific, not a global state, so we don't want it tied in here) bulach 2013/06/05 19:02:11 yeah, I'm ambivalent of these levels... on one han Show quoted text On 2013/06/05 16:51:23, joth wrote: > these need some descriptions. > Tom's suggestions of time it takes to recreate in the bug is nice starting point > - although that depends on the foreground/background state too of the 'thing' > being dropped, and it may seem confusing to talk about that here too. (It leads > to the question of should this carry for/background state too, but that's domain > specific, not a global state, so we don't want it tied in here) yeah, I'm ambivalent of these levels... on one hand, it seems that having at least _two_ levels is better than none, so individual modules can fine tune their decision. otoh, it makes this more contentious... :) I made it just two levels, with comments, let me know if you think it's enough. background / foreground should be conveyed in some other mechanism, and each module should query that to decide what to flush.
	14 DEFINE_MEMORY_PRESSURE_TYPE(MEMORY_PRESSURE_CRITICAL, 2)

OLD	NEW