Issue 15994020: Remove [NoInterfaceObject] from XPathExpression and NodeIterator

Issue 15994020: Remove [NoInterfaceObject] from XPathExpression and NodeIterator (Closed)

Created:
7 years, 6 months ago by do-not-use

Modified:
7 years, 6 months ago

Reviewers:
haraken, arv (Not doing code reviews), abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove [NoInterfaceObject] from XPathExpression and NodeIterator Remove [NoInterfaceObject] from XPathExpression and NodeIterator to match their respective specifications: - http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathExpression - http://www.w3.org/TR/DOM-Level-2-Traversal-Range/traversal.html#Traversal-NodeIterator This also matches the behavior of WebKit and Firefox. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151813

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -8 lines)			Patch
M	LayoutTests/fast/dom/dom-constructors-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/NodeIterator.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/xml/XPathExpression.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15994020/1

7 years, 6 months ago (2013-06-04 19:21:57 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=8678

7 years, 6 months ago (2013-06-04 20:36:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15994020/1

7 years, 6 months ago (2013-06-05 05:54:19 UTC) #5

Message was sent while issue was closed.

Change committed as 151813

Expand Messages | Collapse Messages