Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 15994016: Support custom window features, such as 'moo=foo'. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
===================================================================
--- content/public/browser/web_contents_delegate.h (revision 198276)
+++ content/public/browser/web_contents_delegate.h (working copy)
@@ -276,21 +276,26 @@
// Allows delegate to control whether a WebContents will be created. Returns
// true to allow the creation. Default is to allow it. In cases where the
- // delegate handles the creation/navigation itself, it will use |target_url|.
+ // delegate handles the creation/navigation itself, it will use the values
+ // within |target_url| and |params| to get information on the target site,
+ // size and position of the window, etc.
virtual bool ShouldCreateWebContents(
WebContents* web_contents,
int route_id,
WindowContainerType window_container_type,
const string16& frame_name,
- const GURL& target_url);
+ const GURL& target_url,
+ const WebKit::WindowFeatures& web_window_features);
// Notifies the delegate about the creation of a new WebContents. This
// typically happens when popups are created.
- virtual void WebContentsCreated(WebContents* source_contents,
- int64 source_frame_id,
- const string16& frame_name,
- const GURL& target_url,
- WebContents* new_contents) {}
+ virtual void WebContentsCreated(
+ WebContents* source_contents,
+ int64 source_frame_id,
+ const string16& frame_name,
+ const GURL& target_url,
+ const WebKit::WindowFeatures& web_window_features,
+ WebContents* new_contents) {}
// Notifies the delegate that the content restrictions for this tab has
// changed.

Powered by Google App Engine
This is Rietveld 408576698