Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 15994016: Support custom window features, such as 'moo=foo'. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/view_messages.h » ('j') | content/public/common/window_container_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
===================================================================
--- content/browser/web_contents/web_contents_impl.cc (revision 198276)
+++ content/browser/web_contents/web_contents_impl.cc (working copy)
@@ -1340,8 +1340,12 @@
const ViewHostMsg_CreateWindow_Params& params,
SessionStorageNamespace* session_storage_namespace) {
if (delegate_ && !delegate_->ShouldCreateWebContents(
- this, route_id, params.window_container_type, params.frame_name,
- params.target_url)) {
+ this,
+ route_id,
+ params.window_container_type,
+ params.frame_name,
+ params.target_url,
+ params.window_features)) {
GetRenderViewHost()->GetProcess()->ResumeRequestsForView(route_id);
return;
}
@@ -1419,7 +1423,7 @@
if (delegate_) {
delegate_->WebContentsCreated(
this, params.opener_frame_id, params.frame_name,
- params.target_url, new_contents);
+ params.target_url, params.window_features, new_contents);
}
if (params.opener_suppressed) {
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/view_messages.h » ('j') | content/public/common/window_container_type.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698