Issue 15994011: MIPS: Deprecate FACTORY helper macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15994011: MIPS: Deprecate FACTORY helper macro. (Closed)

Created:
7 years, 6 months ago by kilvadyb

Modified:
7 years, 6 months ago

Reviewers:
kisg, Paul Lind, palfia, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Deprecate FACTORY helper macro. Port r14931 (a914442) Original commit message: This removes the FACTORY helper macro to avoid accidental TLS access when using the factory. Most internal code has access to the Isolate by now whereas tests which are not performance critical still heavily use TLS access through explicit Isolate::Current() calls. BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Committed as r14942.

Expand Messages | Collapse Messages