Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 15994006: Use GL_ALPHA instead of GL_RED to create texture in mesa if no GL_ARB_texture_rg extension (Closed)

Created:
7 years, 6 months ago by yunchao
Modified:
7 years, 6 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use GL_ALPHA instead of GL_RED to create texture in mesa if it no GL_ARB_texture_rg extension. bsalomon submitted another patch related to this, see: https://codereview.chromium.org/16955005/

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yunchao
Use GL_ALPHA instead of GL_RED to create texture in mesa if it doesn't have GL_ARB_texture_rg ...
7 years, 6 months ago (2013-06-04 08:32:26 UTC) #1
yunchao
On 2013/06/04 08:32:26, yunchao wrote: > Use GL_ALPHA instead of GL_RED to create texture in ...
7 years, 6 months ago (2013-06-13 02:01:39 UTC) #2
bsalomon
On 2013/06/13 02:01:39, yunchao wrote: > On 2013/06/04 08:32:26, yunchao wrote: > > Use GL_ALPHA ...
7 years, 6 months ago (2013-06-13 13:09:47 UTC) #3
yunchao
7 years, 6 months ago (2013-06-14 03:47:43 UTC) #4
On 2013/06/13 13:09:47, bsalomon wrote:
> On 2013/06/13 02:01:39, yunchao wrote:
> > On 2013/06/04 08:32:26, yunchao wrote:
> > > Use GL_ALPHA instead of GL_RED to create texture in mesa if it doesn't
have
> > > GL_ARB_texture_rg extension, although GL_ARB_texture_rg(who contain GL_R8,
> > > GL_RED, etc) should be supported when GLVersion is above 3.0.
> > 
> > bsalomon and robertphillips, any comments about this?
> 
> yunchao, can you check whether this CL works:
> 
> https://codereview.chromium.org/16955005/
> 
> I don't have a system handy to test with.
> 
> I wanted to generalize the detection of mesa since we may find other
> differences. (We should do the same for ANGLE on the windows side to remove
some
> of our compile time macros).

Hi, bsalomon, the CL works. I have tested on my desktop with mesa.

Powered by Google App Engine
This is Rietveld 408576698