Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: tests/corelib/expando_test.dart

Issue 1599393003: Use WeakMap to support Expando if available. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/core_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/expando_test.dart
diff --git a/tests/corelib/expando_test.dart b/tests/corelib/expando_test.dart
index d55aecf95c0ac970b4622ba98a1b65096924b0aa..a7fb1c43b5e6d247574db77a81e4678feac850cd 100644
--- a/tests/corelib/expando_test.dart
+++ b/tests/corelib/expando_test.dart
@@ -18,7 +18,7 @@ class ExpandoTest {
testUnnamedExpando(object);
}
for (var object in legal) {
- Expect.equals(2, visits[object]);
+ Expect.equals(2, visits[object], "$object");
}
testIllegal();
testIdentity();
@@ -65,19 +65,19 @@ class ExpandoTest {
static testIllegal() {
Expando<int> expando = new Expando<int>();
Expect.throws(() => expando[null], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "null");
Expect.throws(() => expando['string'], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "'string'");
Expect.throws(() => expando['string'], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "'string'");
Expect.throws(() => expando[42], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "42");
Expect.throws(() => expando[42.87], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "42.87");
Expect.throws(() => expando[true], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "true");
Expect.throws(() => expando[false], (exception)
- => exception is ArgumentError);
+ => exception is ArgumentError, "false");
}
static testIdentity() {
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/core_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698