Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1599303008: [NaCl SDK] Fix "make debug" command. (Closed)

Created:
4 years, 11 months ago by binji
Modified:
4 years, 11 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix "make debug" command. BUG=none R=sbc@chromium.org Committed: https://crrev.com/c471384b5afde8f3f64e527d77399bfc22c229cf Cr-Commit-Position: refs/heads/master@{#371113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M native_client_sdk/src/tools/common.mk View 2 chunks +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 11 months ago (2016-01-21 00:16:28 UTC) #1
Sam Clegg
lgtm
4 years, 11 months ago (2016-01-21 00:34:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1599303008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1599303008/1
4 years, 11 months ago (2016-01-23 00:48:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-23 01:25:10 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 01:26:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c471384b5afde8f3f64e527d77399bfc22c229cf
Cr-Commit-Position: refs/heads/master@{#371113}

Powered by Google App Engine
This is Rietveld 408576698