src/regexp/x64/regexp-macro-assembler-x64.h - Issue 1599303002: [regexp] implement case-insensitive unicode regexps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/x64/regexp-macro-assembler-x64.h

Issue 1599303002: [regexp] implement case-insensitive unicode regexps. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@unicodeclass

Patch Set: fixes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/regexp/x64/regexp-macro-assembler-x64.h

diff --git a/src/regexp/x64/regexp-macro-assembler-x64.h b/src/regexp/x64/regexp-macro-assembler-x64.h

index 257804739f0b4623baa60c0123b6e5e5f9edb109..4c37771d3804cd9342f582c0667b5d35d03e4fc0 100644

--- a/src/regexp/x64/regexp-macro-assembler-x64.h

+++ b/src/regexp/x64/regexp-macro-assembler-x64.h

@@ -38,7 +38,7 @@ class RegExpMacroAssemblerX64: public NativeRegExpMacroAssembler {

virtual void CheckNotBackReference(int start_reg, bool read_backward,

Label* on_no_match);

virtual void CheckNotBackReferenceIgnoreCase(int start_reg,

- bool read_backward,

+ bool read_backward, bool unicode,

Label* on_no_match);

virtual void CheckNotCharacter(uint32_t c, Label* on_not_equal);

virtual void CheckNotCharacterAfterAnd(uint32_t c,

« src/regexp/jsregexp.cc ('K') | « src/regexp/regexp-parser.cc ('k') | src/regexp/x64/regexp-macro-assembler-x64.cc » ('j') | no next file with comments »