REVERTED cros: Update charging not reliable battery status

REVERTED cros: Update charging not reliable battery status

Don't display the "charging not reliable" battery status in the
non-charging-non-discharging state, as that can happen normally in
some circumstances. Also, update the string to be more human-friendly.
See bug for details.

BUG=246336
TEST=manual, see bug
R=derat@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204085

[James Cook, 2013-06-04 18:09:15]

Dan, this is an update to https://codereview.chromium.org/16057022/ - laforge
asked me to hard-code the string in C++.

[Daniel Erat, 2013-06-04 19:23:15]

lgtm

https://codereview.chromium.org/15993020/diff/1/ash/system/chromeos/power/pow...
File ash/system/chromeos/power/power_status_view.cc (right):

https://codereview.chromium.org/15993020/diff/1/ash/system/chromeos/power/pow...
ash/system/chromeos/power/power_status_view.cc:135: ?
GetChargingUnreliableString()
this style seems strange to me -- i think that i've usually seen the '?' and ':'
go on the ends of the previous lines. the push seems to be to cram everything
onto fewer lines, too, so i'd recommend the following:

  battery_time_status = is_charging_unreliable ?
      GetChargingUnreliableString() :
      rb.GetLocalizedString(IDS_ASH_STATUS_TRAY_BATTERY_CALCULATING);

[do not use, 2013-06-04 19:48:33]

This style is automatically generated by the clang-format tool. I don't
like the ? on the front either, but there's a FAQ entry about the decision
at go/clang-format

I'll change this one because it's possible to go to fewer lines, but you
may see more of this pattern as people move to clang-format.



On Tue, Jun 4, 2013 at 12:23 PM, <derat@chromium.org> wrote:

> lgtm
>
>
>
>
> https://codereview.chromium.**org/15993020/diff/1/ash/**
>
system/chromeos/power/power_**status_view.cc<https://codereview.chromium.org/15993020/diff/1/ash/system/chromeos/power/power_status_view.cc>
> File ash/system/chromeos/power/**power_status_view.cc (right):
>
> https://codereview.chromium.**org/15993020/diff/1/ash/**
>
system/chromeos/power/power_**status_view.cc#newcode135<https://codereview.chromium.org/15993020/diff/1/ash/system/chromeos/power/power_status_view.cc#newcode135>
> ash/system/chromeos/power/**power_status_view.cc:135: ?
> GetChargingUnreliableString()
> this style seems strange to me -- i think that i've usually seen the '?'
> and ':' go on the ends of the previous lines. the push seems to be to
> cram everything onto fewer lines, too, so i'd recommend the following:
>
>   battery_time_status = is_charging_unreliable ?
>       GetChargingUnreliableString() :
>       rb.GetLocalizedString(IDS_ASH_**STATUS_TRAY_BATTERY_**CALCULATING);
>
>
https://codereview.chromium.**org/15993020/<https://codereview.chromium.org/1...
>

[James Cook, 2013-06-04 23:58:48]

Committed patchset #2 manually as r204085 (presubmit successful).

[James Cook, 2013-06-06 21:10:23]

On 2013/06/04 23:58:48, James Cook (Chromium) wrote:
> Committed patchset #2 manually as r204085 (presubmit successful).

Reverted at r204589 - I'm going to backport it over as a string in the .grd
file, not hard-coded like this.