Issue 15993014: hydrogen: split switch optimization code into multiple functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15993014: hydrogen: split switch optimization code into multiple functions (Closed)

Created:
7 years, 6 months ago by indutny

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev, titzer

Base URL:
gh:v8/v8.git@master

Visibility:
Public.

More Reviews

Description

hydrogen: split switch optimization code into multiple functions In preparions for future switch statement optimization improvements. R=svenpanne@chromium.org BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -69 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/hydrogen.cc	View		4 chunks	+82 lines, -69 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 6 months ago (2013-06-05 07:25:10 UTC) #2

Given the fact that we don't have a clear plan how to proceed regarding the
compilation of switch statements, I don't think that simply moving the tail of
the VisitSwitchStatement to a separate method is really worthwhile.

Expand Messages | Collapse Messages