chrome/android/java/res/values/dimens.xml - Issue 15992008: [Android] Fixed default bookmark shortcut icon drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 15992008: [Android] Fixed default bookmark shortcut icon drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes on newt's comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values-sw800dp/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index ca03b411d6b2788f49e991e0eea8fa9f605ef8a0..2809b17b1e94802fd159740356588166c2b92cec 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -6,16 +6,7 @@

-->

-

- <dimen name="favicon_size">16dp</dimen>

- <dimen name="favicon_colorstrip_width">32dp</dimen>

- <dimen name="favicon_colorstrip_height">2dp</dimen>

- <dimen name="favicon_colorstrip_padding">6dp</dimen>

- <dimen name="favicon_colorstrip_corner_radii">1dp</dimen>

- <dimen name="favicon_fold_size">8dp</dimen>

- <dimen name="favicon_fold_corner_radii">1dp</dimen>

- <dimen name="favicon_fold_shadow">2dp</dimen>

- <dimen name="favicon_fold_border">1px</dimen>

+

newt (away) 2013/05/31 03:10:56 since this is only used in once place, I'd remove

Kibeom Kim (inactive) 2013/05/31 06:38:03 Done.