chrome/android/java/res/values-sw600dp/dimens.xml - Issue 15992008: [Android] Fixed default bookmark shortcut icon drawing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values-sw600dp/dimens.xml

Issue 15992008: [Android] Fixed default bookmark shortcut icon drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/mipmap-xhdpi/homescreen_bg_overlay.png ('k') | chrome/android/java/res/values-sw800dp/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <resources>	8 <resources>

9 <!-- Favicon dimensions. Used to create bookmark shortcut images. -->	9 <!-- Favicon dimensions. Used to create bookmark shortcut images. -->

10 <dimen name="favicon_size">21dp</dimen>	10 <dimen name="favicon_size">24dp</dimen>
	newt (away) 2013/05/30 22:12:01 how about removing this and calculating the value how about removing this and calculating the value based on getLauncherLargeIconSize()? that would remove the final dependency on screen size, which usually correlates to bookmark icon size... but not always. Kibeom Kim (inactive) 2013/05/31 01:23:52 Done. Show quoted text On 2013/05/30 22:12:01, newt wrote: > how about removing this and calculating the value based on > getLauncherLargeIconSize()? that would remove the final dependency on screen > size, which usually correlates to bookmark icon size... but not always. Done.
11 <dimen name="favicon_colorstrip_width">43dp</dimen>

12 <dimen name="favicon_colorstrip_height">3dp</dimen>

13 <dimen name="favicon_colorstrip_padding">8dp</dimen>

14 <dimen name="favicon_colorstrip_corner_radii">1dp</dimen>

15 <dimen name="favicon_fold_size">10dp</dimen>

16 <dimen name="favicon_fold_corner_radii">1dp</dimen>

17 <dimen name="favicon_fold_shadow">3dp</dimen>

18 </resources>	11 </resources>

OLD	NEW