Issue 159913004: Stop handling the case where oldDocument and newDocument are the same in adoptDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159913004: Stop handling the case where oldDocument and newDocument are the same in adoptDocument() (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Stop handling the case where oldDocument and newDocument are the same in adoptDocument() Stop handling the case where oldDocument and newDocument are the same in NodeListsNodeData::adoptDocument(). Replace the if check by an assertion as all the callers already make sure to call this method only if the oldDocument and the newDocument are different. R=eseidel, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166981

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	Source/core/dom/NodeRareData.h	View		1 chunk	+14 lines, -15 lines	0 comments	Download
	M	Source/core/dom/TreeScopeAdopter.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/159913004/1

6 years, 10 months ago (2014-02-12 03:53:04 UTC) #3

Message was sent while issue was closed.

Change committed as 166981

Expand Messages | Collapse Messages