Fix org.chromium.chrome.browser.GeolocationTest

Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_on_load.html
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_watch_on_load.html
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness

Committed: https://crrev.com/5228d5afe9d76431d7cca53eb1ea73b715e49e7e
Cr-Commit-Position: refs/heads/master@{#370807}

[pkotwicz, 2016-01-18 18:31:28]

pkotwicz@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[pkotwicz, 2016-01-18 18:31:29]

mvanouwerkerk@ can you please take a look?

[pkotwicz, 2016-01-20 15:45:44]

mvanouwerkerk@chromium.org Ping!

[pkotwicz, 2016-01-21 18:24:27]

pkotwicz@chromium.org changed reviewers:
+ tedchoc@chromium.org

[pkotwicz, 2016-01-21 18:24:28]

tedchoc@ can you please take a look?

I am not too sure who is the best reviewer for this CL

[Ted C, 2016-01-21 21:12:22]

probably not me honestly, but the change seems reasonable and looks good so lgtm

[pkotwicz, 2016-01-21 21:14:26]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-01-21 21:15:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1599113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1599113002/1

[commit-bot: I haz the power, 2016-01-21 22:35:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-21 22:36:37]

Description was changed from

==========
Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness
==========

to

==========
Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness

Committed: https://crrev.com/5228d5afe9d76431d7cca53eb1ea73b715e49e7e
Cr-Commit-Position: refs/heads/master@{#370807}
==========

[commit-bot: I haz the power, 2016-01-21 22:36:37]

Patchset 1 (id:??) landed as
https://crrev.com/5228d5afe9d76431d7cca53eb1ea73b715e49e7e
Cr-Commit-Position: refs/heads/master@{#370807}

[mikecase (-- gone --), 2016-01-22 01:45:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1614843005/ by mikecase@chromium.org.

The reason for reverting is: Causing downstream test failures on ToT bots
(blocking Chromium rolls downstream).