Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3009)

Unified Diff: chrome/plugin/webplugin_proxy.cc

Issue 159907: linux: fix windowless Flash when scrolling (Closed)
Patch Set: address review comments Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/plugins/webplugin_delegate_impl_gtk.cc » ('j') | webkit/glue/webplugin_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/webplugin_proxy.cc
diff --git a/chrome/plugin/webplugin_proxy.cc b/chrome/plugin/webplugin_proxy.cc
index 6aee64561f1c391a623fde987b7be23c719efd92..0e2e006f47760656b78ad1734fcc6e62b08ca8d0 100644
--- a/chrome/plugin/webplugin_proxy.cc
+++ b/chrome/plugin/webplugin_proxy.cc
@@ -182,6 +182,12 @@ void WebPluginProxy::InvalidateRect(const gfx::Rect& rect) {
// Ignore NPN_InvalidateRect calls with empty rects. Also don't send an
// invalidate if it's outside the clipping region, since if we did it won't
// lead to a paint and we'll be stuck waiting forever for a DidPaint response.
+ //
+ // TODO(piman): There is a race condition here, because this test assumes
+ // that when the paint actually occurs, the clip rect will not have changed.
+ // This is not true because scrolling (or window resize) could occur and be
+ // handled by the renderer before it receives the InvalidateRect message,
+ // changing the clip rect and then not painting.
if (rect.IsEmpty() || !delegate_->GetClipRect().Intersects(rect))
return;
« no previous file with comments | « no previous file | webkit/glue/plugins/webplugin_delegate_impl_gtk.cc » ('j') | webkit/glue/webplugin_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698