Fix assignment of function name constant.

Fix assignment of function name constant.

If it's shadowed by a variable of the same name and both are forcibly
context-allocated, the function is assigned to the wrong context slot.


R=rossberg@chromium.org
BUG=v8:3138
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=19379

[Yang, 2014-02-12 14:59:02]

On 2014/02/12 14:58:07, Yang wrote:

In a rare twist, only fullcodegen, not crankshaft, is affected.

[rossberg, 2014-02-14 11:56:21]

LGTM with comment

https://codereview.chromium.org/159903008/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-3138.js (right):

https://codereview.chromium.org/159903008/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-3138.js:23: with ( {} ) const a = 3;
How exactly is this test related?

Can we either remove it, or at least change it so that it is compatible with
upcoming ES6 semantics?

[Yang, 2014-02-14 12:40:56]

Committed patchset #2 manually as r19379 (presubmit successful).

[Yang, 2014-02-14 12:40:57]

On 2014/02/14 11:56:21, rossberg wrote:
> LGTM with comment
> 
>
https://codereview.chromium.org/159903008/diff/1/test/mjsunit/regress/regress...
> File test/mjsunit/regress/regress-3138.js (right):
> 
>
https://codereview.chromium.org/159903008/diff/1/test/mjsunit/regress/regress...
> test/mjsunit/regress/regress-3138.js:23: with ( {} ) const a = 3;
> How exactly is this test related?
> 
> Can we either remove it, or at least change it so that it is compatible with
> upcoming ES6 semantics?

Changed test case as discussed offline.