Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 159903007: Do not change IME label in tray before hiding it. (Closed)

Created:
6 years, 10 months ago by dzhioev (left Google)
Modified:
6 years, 10 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Do not change IME label in tray before hiding it. BUG=343650 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ash/system/ime/tray_ime.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dzhioev (left Google)
Hi, please review. When we switch from user that has two kb layouts to user ...
6 years, 10 months ago (2014-02-12 13:25:16 UTC) #1
jennyz
lgtm. Would you please file a bug with repro steps and associate the cl with ...
6 years, 10 months ago (2014-02-12 17:22:07 UTC) #2
dzhioev (left Google)
On 2014/02/12 17:22:07, jennyz wrote: > lgtm. Would you please file a bug with repro ...
6 years, 10 months ago (2014-02-13 21:03:24 UTC) #3
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 10 months ago (2014-02-13 21:03:33 UTC) #4
jennyz
Thanks! Jenny On Thu, Feb 13, 2014 at 1:03 PM, <dzhioev@chromium.org> wrote: > On 2014/02/12 ...
6 years, 10 months ago (2014-02-13 21:05:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/159903007/1
6 years, 10 months ago (2014-02-13 21:07:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 23:10:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263833
6 years, 10 months ago (2014-02-13 23:10:35 UTC) #8
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 10 months ago (2014-02-14 13:44:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/159903007/1
6 years, 10 months ago (2014-02-14 13:45:14 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:38:44 UTC) #11
Message was sent while issue was closed.
Change committed as 251337

Powered by Google App Engine
This is Rietveld 408576698