[Mac] Cache the BWC to use when releasing bar visibility for the bookmark bub...

[Mac] Close bookmark bubbles when toggling fullscreen mode.

BUG=40716
TEST=See test case in bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52873

[rohitrao (OOO until 6-22), 2010-07-14 18:49:13]

I've been sitting on this CL forever.  I don't think caching the BWC will cause
trouble, because the bubble always goes away before the controller (correct me
if I'm wrong).

[viettrungluu, 2010-07-14 19:59:44]

On 2010/07/14 18:49:13, rohitrao wrote:
> I've been sitting on this CL forever.  I don't think caching the BWC will
cause
> trouble, because the bubble always goes away before the controller (correct me
> if I'm wrong).

I don't know, but the when I last look at the code (a long time ago), the
bookmark bubble going away was prone to race conditions. Try upping the fade-out
time on the bookmark bubble and seeing if you can get it to crash (but maybe
that's been fixed?).

[viettrungluu, 2010-07-14 20:00:37]

+thakis since he's looked at more bubbly stuff in recent memory.

[Nico, 2010-07-14 20:04:58]

On 2010/07/14 20:00:37, viettrungluu wrote:
> +thakis since he's looked at more bubbly stuff in recent memory.

My context-missing comment is that the Right Fix seems to put a call to close
the bookmark bubble into the browser code that runs when fullscreen is about to
be triggered. (Linux / windows don't have this problem because they ignore
keyboard shortcuts when a bubble has focus afaiu)

[rohitrao (OOO until 6-22), 2010-07-14 20:28:31]

This feels safer.  Are there any other bubbles that need to be closed before
going fullscreen?  Why don't we do something similar before closing the browser
window?

[Nico, 2010-07-14 20:30:59]

Probably "all bubbles"?

Some of them also need to be closed on cmd-t (I have an open bug on me
for that).

When closing the browser window, the bubble sees that its parent
window is closing and closes itself.

On Wed, Jul 14, 2010 at 1:28 PM,  <rohitrao@chromium.org> wrote:
> This feels safer.  Are there any other bubbles that need to be closed before
> going fullscreen?  Why don't we do something similar before closing the
> browser
> window?
>
> http://codereview.chromium.org/1599028/show
>

[rohitrao (OOO until 6-22), 2010-07-14 20:52:16]

On 2010/07/14 20:30:59, Nico wrote:
> Probably "all bubbles"?
> 
> Some of them also need to be closed on cmd-t (I have an open bug on me
> for that).
> 
> When closing the browser window, the bubble sees that its parent
> window is closing and closes itself.

Right, ok.  In terms of locking bar visibility, we only have to make sure that:
1) The BWC is still alive when the bubble closes.
2) The release call comes *before* the bubble moves to a different window.

#2 is what I'm worrying about now, and it can only happen when going fullscreen
and back.  Well, hm.  I wonder what happens if an extension moves a tab to a
different window while the bubble is open? =)

[rohitrao (OOO until 6-22), 2010-07-16 15:51:29]

What do you guys think?  Can I commit this new version?  The other bubbles I've
looked at (extension popups) don't lock the bar yet, so they don't have this
problem.

[Nico, 2010-07-16 19:41:55]

LG

We talked on IRC. I thought it belongs into browser.cc, but rohit pointed out
that only browser_window knows about bubbles, and it's a pure virtual class.