Follow-up of Improve the ProfileInfoCache API

chrome/test/base/testing_profile_manager.cc

Index: chrome/test/base/testing_profile_manager.cc
diff --git a/chrome/test/base/testing_profile_manager.cc b/chrome/test/base/testing_profile_manager.cc
index 2d876eda5c76fd8caac3ec49fc7c3ddcc660039f..2727a7def4ac0fcd7d63fe9594bb5ef931705058 100644
--- a/chrome/test/base/testing_profile_manager.cc
+++ b/chrome/test/base/testing_profile_manager.cc
@@ -10,6 +10,7 @@
 #include "base/memory/ref_counted.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
+#include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_constants.h"
@@ -235,6 +236,10 @@ ProfileInfoCache* TestingProfileManager::profile_info_cache() {
   return &profile_manager_->GetProfileInfoCache();
 }
 
+ProfileAttributesStorage* TestingProfileManager::profile_attributes_storage() {
+  return profile_info_cache();

[sky, 2016/01/20 16:19:55]

Why do you need this function? Can't callers use profile_info_cache() directly?
I don't see any test code calling this function. Am I missing something?

[lwchkg, 2016/01/21 14:41:17]

1. We plan to replace profile_info_cache() by this function later. But at this
stage it is only a thin wrapper around profile_info_cache().

2. AFAIK no code is calling this function now. But we do plan to replace all
test code calling profile_info_cache() by this function right after this CL
lands.

Anyway, this CL is one of a long series of CLs in the refactoring of
ProfileInfoCache. The plan is written in the last page of the following
document:
https://docs.google.com/a/google.com/document/d/12V8ahA9lEsXWyT8OqasEz3HR4J5j...
(I'm not sure if this is written by Anthony, or by an old c/b/profile owner.)

FYI, here is a past CL that was committed:
https://codereview.chromium.org/1214483002/ (by Anthony)

And several CLs that has never exited draft. This CL is entirely extracted from
the first CL in the list.
https://codereview.chromium.org/1242793005/ (by Anthony)
https://codereview.chromium.org/33753002/   (by noms (Monica), 2yrs ago)
https://codereview.chromium.org/8539043/    (by Sailesh, 4yrs ago)

+}
+
 void TestingProfileManager::SetUpInternal() {
   ASSERT_FALSE(browser_process_->profile_manager())
       << "ProfileManager already exists";