src/ia32/code-stubs-ia32.cc - Issue 15990004: Generators: Avoid calling into runtime if operand stack is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 15990004: Generators: Avoid calling into runtime if operand stack is empty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add asserts to runtime.cc; clarify generated runtime call Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index f3483eb3e1676000a71e0f530f8d57e7f649954c..91dd9df93db65a87bdb6a739e1d8b3f1f0bf0516 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -5050,11 +5050,6 @@ void CEntryStub::GenerateCore(MacroAssembler* masm,

Label okay;

__ cmp(eax, masm->isolate()->factory()->the_hole_value());

__ j(not_equal, &okay, Label::kNear);

- // TODO(wingo): Currently SuspendJSGeneratorObject returns the hole. Change

- // to return another sentinel like a harmony symbol.

- __ cmp(ebx, Immediate(ExternalReference(

- Runtime::kSuspendJSGeneratorObject, masm->isolate())));

- __ j(equal, &okay, Label::kNear);

__ int3();

__ bind(&okay);

}

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »