Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 15990003: Fix and rebaseline fast/js/constructor-length.html (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Fix and rebaseline fast/js/constructor-length.html Fix fast/js/constructor-length.html so that the SharedWorker constructor length is expected to be 1, not 2. As per its specification, the constructor only have 1 *mandatory* argument: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#shared-workers-and-the-sharedworker-interface The test is also rebaselined and unskipped. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/ContentShellTestExpectations View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-24 11:21:57 UTC) #1
haraken
LGTM
7 years, 7 months ago (2013-05-24 11:24:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15990003/1
7 years, 7 months ago (2013-05-24 11:24:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10000
7 years, 7 months ago (2013-05-24 12:28:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15990003/1
7 years, 7 months ago (2013-05-24 12:32:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10028
7 years, 7 months ago (2013-05-24 13:39:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15990003/1
7 years, 7 months ago (2013-05-24 13:48:18 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 13:49:13 UTC) #8
Message was sent while issue was closed.
Change committed as 151094

Powered by Google App Engine
This is Rietveld 408576698